Welcome!

Microservices Expo Authors: Liz McMillan, Pat Romanski, Elizabeth White, Yeshim Deniz, Zakia Bouachraoui

Related Topics: Microservices Expo, Java IoT, Industrial IoT, Machine Learning , Release Management , Cloud Security

Microservices Expo: Blog Post

What’s Not So Obvious About Code Reviews

Effective code reviews

When conducting code reviews then you should determine if code reviews are just something you check off your list or have they actually gotten you closer to better quality code? Your motivations and attitudes towards code reviews can greatly affect their effectiveness.

When my son started preschool at three years old he was expected to put his shoes on by himself. One of the first directions his teacher gave me was to say nothing if he put them on the wrong feet. I soon came to understand the wisdom of this approach. He wore his shoes on the wrong feet for a few days before figuring out how to get it right all by himself. The important thing is that once he learned he never got it wrong again. People retain information better when they are allowed to learn for themselves rather than if the information is spoon-fed to them.

Many years ago I started a new job with a consulting firm as a junior programmer. As soon as I had written just a little bit of code they scheduled a review for it. It was obvious that they wanted me to comply with standards and catch my mistakes. The code review was uncomfortable, I felt that I was being judged and I can't remember that I learned anything from it that improved the quality of my code on the long run. Now many years down the road as a manager of a technical team I am a stickler for code reviews myself. However, I've learned that being successful with code reviews depends on why you have them and how they are conducted.

As a manager I almost never code myself but am responsible for code quality. I love being part of collaborative code reviews because they are an enormous learning opportunity for me. I get to see what's in the code for myself and hear different points of view. At one point I was leading two different teams and code reviews were a great way to get developers on each team familiar with each other's code. When appropriate, I included our business analysts in some of the reviews so that they could verify some of the most confusing logic. Junior team members were able to share their opinions without fear. Sometimes they would notice someone else's work and liked it so much that they signed up to rework their code voluntarily. I noticed that the team was largely able to come to consensus all by itself and my role during the reviews was that of an observer and guide.

I tracked the outcome of our code reviews as tasks in our project management tool to make sure that we followed through on all of the decisions that we made during these reviews.

I believe that if code reviews are conducted collaboratively and in the spirit of learning and self-improvement then they can lead not only to better code but also to better communications and improved morale.

More Stories By Salma Saad

Salma started her career back in 1993, working on Steve Jobs NeXT platform and moved on to Java when it was at the ‘bleeding edge’. She has worked as a consultant for more than ten years, working primarily on website development projects for a large variety of clients. In addition to her fascination with everything technical she also has a strong interest in developing her leadership and management expertise. She enjoys living in Chicago and being the mother of two rugrats, ...um boys and is currently working for Arc Worldwide/Leo Burnett helping fortune 500 clients build awe-inspiring websites.

Microservices Articles
Modern software design has fundamentally changed how we manage applications, causing many to turn to containers as the new virtual machine for resource management. As container adoption grows beyond stateless applications to stateful workloads, the need for persistent storage is foundational - something customers routinely cite as a top pain point. In his session at @DevOpsSummit at 21st Cloud Expo, Bill Borsari, Head of Systems Engineering at Datera, explored how organizations can reap the bene...
In his session at 20th Cloud Expo, Mike Johnston, an infrastructure engineer at Supergiant.io, discussed how to use Kubernetes to set up a SaaS infrastructure for your business. Mike Johnston is an infrastructure engineer at Supergiant.io with over 12 years of experience designing, deploying, and maintaining server and workstation infrastructure at all scales. He has experience with brick and mortar data centers as well as cloud providers like Digital Ocean, Amazon Web Services, and Rackspace. H...
DevOpsSummit New York 2018, colocated with CloudEXPO | DXWorldEXPO New York 2018 will be held November 11-13, 2018, in New York City. Digital Transformation (DX) is a major focus with the introduction of DXWorldEXPO within the program. Successful transformation requires a laser focus on being data-driven and on using all the tools available that enable transformation if they plan to survive over the long term.
Most DevOps journeys involve several phases of maturity. Research shows that the inflection point where organizations begin to see maximum value is when they implement tight integration deploying their code to their infrastructure. Success at this level is the last barrier to at-will deployment. Storage, for instance, is more capable than where we read and write data. In his session at @DevOpsSummit at 20th Cloud Expo, Josh Atwell, a Developer Advocate for NetApp, will discuss the role and value...
CloudEXPO New York 2018, colocated with DXWorldEXPO New York 2018 will be held November 11-13, 2018, in New York City and will bring together Cloud Computing, FinTech and Blockchain, Digital Transformation, Big Data, Internet of Things, DevOps, AI, Machine Learning and WebRTC to one location.
SYS-CON Events announced today that DatacenterDynamics has been named “Media Sponsor” of SYS-CON's 18th International Cloud Expo, which will take place on June 7–9, 2016, at the Javits Center in New York City, NY. DatacenterDynamics is a brand of DCD Group, a global B2B media and publishing company that develops products to help senior professionals in the world's most ICT dependent organizations make risk-based infrastructure and capacity decisions.
Consumer-driven contracts are an essential part of a mature microservice testing portfolio enabling independent service deployments. In this presentation we'll provide an overview of the tools, patterns and pain points we've seen when implementing contract testing in large development organizations.
Containers and Kubernetes allow for code portability across on-premise VMs, bare metal, or multiple cloud provider environments. Yet, despite this portability promise, developers may include configuration and application definitions that constrain or even eliminate application portability. In this session we'll describe best practices for "configuration as code" in a Kubernetes environment. We will demonstrate how a properly constructed containerized app can be deployed to both Amazon and Azure ...
In his general session at 19th Cloud Expo, Manish Dixit, VP of Product and Engineering at Dice, discussed how Dice leverages data insights and tools to help both tech professionals and recruiters better understand how skills relate to each other and which skills are in high demand using interactive visualizations and salary indicator tools to maximize earning potential. Manish Dixit is VP of Product and Engineering at Dice. As the leader of the Product, Engineering and Data Sciences team at D...
In his session at 20th Cloud Expo, Scott Davis, CTO of Embotics, discussed how automation can provide the dynamic management required to cost-effectively deliver microservices and container solutions at scale. He also discussed how flexible automation is the key to effectively bridging and seamlessly coordinating both IT and developer needs for component orchestration across disparate clouds – an increasingly important requirement at today’s multi-cloud enterprise.